Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2904010: Fix acquisition of thumbnail images in Linux (Closed)

Created:
10 years, 5 months ago by jwillcox
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
git@github.com:litl/big-chromium.git
Visibility:
Public.

Description

Fix acquisition of thumbnail images on Linux Contributed by jwillcox@litl.com BUG=48066 TEST=Load a page from new tab page, then ensure the thumbnail is updated by viewing the new tab page again

Patch Set 1 #

Total comments: 2

Patch Set 2 : Flip the logic, add 'litl LLC' to AUTHORS #

Patch Set 3 : Added my name to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M AUTHORS View 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_x.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jwillcox
10 years, 5 months ago (2010-07-10 17:24:43 UTC) #1
scherkus (not reviewing)
The one thing I'm confused about is the CL description vs. the change. This security ...
10 years, 5 months ago (2010-07-13 21:23:17 UTC) #2
jwillcox
http://codereview.chromium.org/2904010/diff/1/2 File chrome/browser/renderer_host/backing_store_x.cc (right): http://codereview.chromium.org/2904010/diff/1/2#newcode329 chrome/browser/renderer_host/backing_store_x.cc:329: (std::numeric_limits<size_t>::max() / image->bytes_per_line) < On 2010/07/13 21:23:19, scherkus wrote: ...
10 years, 5 months ago (2010-07-15 15:31:04 UTC) #3
jwillcox
BTW, I don't have commit access, so if this is ok now could you please ...
10 years, 5 months ago (2010-07-15 19:21:07 UTC) #4
scherkus (not reviewing)
Whoops sorry for not recognizing this sooner! Could we get your full name added to ...
10 years, 5 months ago (2010-07-26 20:36:58 UTC) #5
jwillcox
On 2010/07/26 20:36:58, scherkus wrote: > Whoops sorry for not recognizing this sooner! No worries ...
10 years, 5 months ago (2010-07-26 20:56:03 UTC) #6
scherkus (not reviewing)
10 years, 5 months ago (2010-07-27 00:21:57 UTC) #7
Committed as r53721.

Powered by Google App Engine
This is Rietveld 408576698