Output some error text if one of these Wait functions should timeout....

Output some error text if one of these Wait functions should timeout.

R=phajdan.jr
BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52286

[Paweł Hajdan Jr., 2010-07-14 00:16:58]

LGTM!

http://codereview.chromium.org/2903012/diff/1/2
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/2903012/diff/1/2#newcode635
chrome/test/ui/ui_test.cc:635: ADD_FAILURE() << "Timeout reached in
WaitForDownloadShelfVisibilityChange";
You might want to add another log message in the other failure case. Like
"Browser crashed in WaitFor...". Similar comment applies to other places in this
file.

[darin (slow to review), 2010-07-14 06:04:14]

On Tue, Jul 13, 2010 at 5:16 PM, <phajdan.jr@chromium.org> wrote:

> LGTM!
>
>
> http://codereview.chromium.org/2903012/diff/1/2
> File chrome/test/ui/ui_test.cc (right):
>
> http://codereview.chromium.org/2903012/diff/1/2#newcode635
> chrome/test/ui/ui_test.cc:635: ADD_FAILURE() << "Timeout reached in
> WaitForDownloadShelfVisibilityChange";
> You might want to add another log message in the other failure case.
> Like "Browser crashed in WaitFor...". Similar comment applies to other
> places in this file.


I thought about that, but those all have an EXPECT_TRUE line, which
would at least generate some output.  My goal was to make it easy
to determine from test output that a Wait* function timed out.  As is,
a timeout is just a silent failure, which means that we only notice the
after-effects of a timeout :-(

-Darin


>
>
> http://codereview.chromium.org/2903012/show
>