Issue 2903009: Roll googleurl r138 for multi-dll build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2903009: Roll googleurl r138 for multi-dll build (Closed)

Created:
10 years, 5 months ago by Victor Wang

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Roll googleurl r138 for multi-dll build R=brettw BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52256

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 5 months ago (2010-07-13 05:44:19 UTC) #2

LGTM

On Mon, Jul 12, 2010 at 8:12 PM,  <victorw@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Roll googleurl r138 for multi-dll build
>
> R=brettw
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/2903009/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 52099)
> +++ DEPS        (working copy)
> @@ -19,7 +19,7 @@
>     "/trunk/deps/support@20411",
>
>   "src/googleurl":
> -    "http://google-url.googlecode.com/svn/trunk@137",
> +    "http://google-url.googlecode.com/svn/trunk@138",
>
>   "src/sdch/open-vcdiff":
>     "http://open-vcdiff.googlecode.com/svn/trunk@28",
>
>
>

Expand Messages | Collapse Messages