Issue 2901008: Add the rest of the content settings tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2901008: Add the rest of the content settings tabs. (Closed)

Created:
10 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
csilv, arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Add the rest of the content settings tabs. Also, convert it to a subpage. Also, make subpage nav items hidden when not in use. BUG=48863 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52251

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+317 lines, -92 lines)			Patch
M	chrome/browser/dom_ui/content_settings_handler.cc	View	1	4 chunks	+82 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/options.html	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/advanced_options.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings.html	View		1 chunk	+224 lines, -77 lines	0 comments	Download
	chrome/browser/resources/options/options_page.css	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options_page.js	View		3 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Evan Stade

I want to add target="_blank" on the links, but for some reason it isn't sticking ...

10 years, 5 months ago (2010-07-13 01:46:26 UTC) #1

arv (Not doing code reviews)

10 years, 5 months ago (2010-07-13 17:17:16 UTC) #2

lgtm

I don't think target="_blank" works for DOMUI due to security restrictions.