Add a run_testserver executable to make it easy to run the testserver...

Add a run_testserver executable to make it easy to run the testserver
standalone.

Example:
$ testserver --doc-root=net/data/url_request_unittest --http

Also supports --https and --ftp.

R=eroman
BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51993

[eroman, 2010-07-09 18:36:14]

LGTM.

Its too bad this can't be a python script.

I understand why you favored doing this in C++, but the downside is it will be
less discoverable to others.

http://codereview.chromium.org/2901006/diff/4001/5001
File net/net.gyp (right):

http://codereview.chromium.org/2901006/diff/4001/5001#newcode878
net/net.gyp:878: 'msvs_guid': '506F2468-6B1D-48E2-A67C-9D9C6BAC0EC5',
Is this necessary? (I thought it was only during our transition to gyp).

http://codereview.chromium.org/2901006/diff/4001/5002
File net/tools/testserver/run_testserver.cc (right):

http://codereview.chromium.org/2901006/diff/4001/5002#newcode45
net/tools/testserver/run_testserver.cc:45: printf("Error: --doc-root must be
specified");
typo: "Error".

http://codereview.chromium.org/2901006/diff/4001/5002#newcode58
net/tools/testserver/run_testserver.cc:58: }
nit: Can you add an else that is NOTREACHED() ?

http://codereview.chromium.org/2901006/diff/4001/5002#newcode61
net/tools/testserver/run_testserver.cc:61: protocol.c_str(),
nit: Can you line this up with the open parenthesis (or else move the first
parameter down a line) ?

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[darin (slow to review), 2010-07-09 19:09:39]

On Fri, Jul 9, 2010 at 11:36 AM, <eroman@chromium.org> wrote:

> LGTM.
>
> Its too bad this can't be a python script.
>
> I understand why you favored doing this in C++, but the downside is it will
> be
> less discoverable to others.
>
>
Yeah... I thought about doing this with a script, but I didn't want to
duplicate all of the PYTHONPATH muckery, and besides this way I knew that it
would work just as well as it does for the unit tests :-)

I'll post to chromium-dev about this new executable once it lands.  Maybe
that will help with discovery.



>
> http://codereview.chromium.org/2901006/diff/4001/5001
> File net/net.gyp (right):
>
> http://codereview.chromium.org/2901006/diff/4001/5001#newcode878
> net/net.gyp:878: 'msvs_guid': '506F2468-6B1D-48E2-A67C-9D9C6BAC0EC5',
> Is this necessary? (I thought it was only during our transition to gyp).
>

I believe it is necessary.  Otherwise, GYP will generate a new GUID each
time, and that'll cause more projects to reload if you leave the sln open in
Visual Studio while running GYP.



>
> http://codereview.chromium.org/2901006/diff/4001/5002
> File net/tools/testserver/run_testserver.cc (right):
>
> http://codereview.chromium.org/2901006/diff/4001/5002#newcode45
> net/tools/testserver/run_testserver.cc:45: printf("Error: --doc-root
> must be specified");
> typo: "Error".
>

hmm?  what typo do you see?


>
> http://codereview.chromium.org/2901006/diff/4001/5002#newcode58
> net/tools/testserver/run_testserver.cc:58: }
> nit: Can you add an else that is NOTREACHED() ?
>

ok


>
> http://codereview.chromium.org/2901006/diff/4001/5002#newcode61
> net/tools/testserver/run_testserver.cc:61: protocol.c_str(),
> nit: Can you line this up with the open parenthesis (or else move the
> first parameter down a line) ?
>

oops, yes.



>
>
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...
>
>
> http://codereview.chromium.org/2901006/show
>

[eroman, 2010-07-09 19:19:21]

LGTM

> hmm?  what typo do you see?

Apparently I am confused, please disregard that comment!