Make NetworkLibrary::UpdateSystemInfo() externally usable, and invoke...

Make NetworkLibrary::UpdateSystemInfo() externally usable, and invoke
it before retrieving/displaying network information, so that we
successfully display data that the user has just changed via another
mechanism.
BUG=chromium-os:3972
TEST=Configure certificates via entd and log out. Log back in and select the
network menu, then (immediately) the relevant SSID. Check for the proper
certificate information, rather than unset fields.

[Charlie Lee, 2010-07-08 19:01:34]

LGTM if there's no added delay in opening up the network menu button. Do you
notice an added delay?

[Nathan Williams, 2010-07-08 19:38:27]

On 2010/07/08 19:01:34, chocobo wrote:
> LGTM if there's no added delay in opening up the network menu button. Do you
> notice an added delay?

Side-by-side testing on an identical system without this patch, I noticed a very
slight delay - I could repeatedly open and close the menu about 4 times a
second, as opposed to 5 times a second without the patch.

[Charlie Lee (do not use), 2010-07-08 19:43:40]

Seems ok for now. A better way would be for the updated data to be pushed  
to us when they change as oppose to have to pull for it each time. Please  
open a bug on that.

LGTM

On Jul 8, 2010 12:38:28 PM PDT, njw <njw@chromium.org> wrote:
>> On 2010/07/08 19:01:34, chocobo wrote:
>> LGTM if there's no added delay in opening up the network menu button.
>> Do you
>> notice an added delay?

> Side-by-side testing on an identical system without this patch, I
> noticed a very
> slight delay - I could repeatedly open and close the menu about 4 times
> a
> second, as opposed to 5 times a second without the patch.

[Nathan Williams, 2010-07-08 20:15:20]

Bug 3972 (that this is in response to) discusses this, and some of the
tradeoffs involved in the different approaches (I already tried approach #1
there, and Sam rightly shot it down as a hack).
At this point I'm more concerned with the robustness of creating and
destroying lots of dbus signal listeners as networks come and go. Is there a
way to leave a breadcrumb on the bug to revisit this at some point, or
should I open another one?

   - Nathan

On Thu, Jul 8, 2010 at 3:43 PM, Charlie Lee <chocobo@google.com> wrote:

> Seems ok for now. A better way would be for the updated data to be pushed
> to us when they change as oppose to have to pull for it each time. Please
> open a bug on that.
>
> LGTM
>
>
> On Jul 8, 2010 12:38:28 PM PDT, njw <njw@chromium.org> wrote:
>
>> On 2010/07/08 19:01:34, chocobo wrote:
>>> LGTM if there's no added delay in opening up the network menu button.
>>> Do you
>>> notice an added delay?
>>>
>>
>  Side-by-side testing on an identical system without this patch, I
>> noticed a very
>> slight delay - I could repeatedly open and close the menu about 4 times
>> a
>> second, as opposed to 5 times a second without the patch.
>>
>

[Charlie Lee (do not use), 2010-07-08 20:55:14]

You should just open another one and mention this bug.

On Jul 8, 2010 1:15:07 PM PDT, Nathan Williams <njw@chromium.org> wrote:
> Bug 3972 (that this is in response to) discusses this, and some of the
> tradeoffs involved in the different approaches (I already tried
> approach #1 there, and Sam rightly shot it down as a hack).At this
> point I'm more concerned with the robustness of creating and destroying
> lots of dbus signal listeners as networks come and go. Is there a way
> to leave a breadcrumb on the bug to revisit this at some point, or
> should I open another one?
> - Nathan

[Nathan Williams, 2010-07-09 19:41:37]

I've opened #4674 for the push/pull tension.

I've also updated the patch to prevent a recursion/lockup that happened in the
internet options dialog (as opposed to the dropdown menu). PTAL, and push it for
me if you approve.

[Charlie Lee, 2010-07-21 19:12:46]

This has been pushed here: http://codereview.chromium.org/3019015/show

On 2010/07/09 19:41:37, Nathan Williams wrote:
> I've opened #4674 for the push/pull tension.
> 
> I've also updated the patch to prevent a recursion/lockup that happened in the
> internet options dialog (as opposed to the dropdown menu). PTAL, and push it
for
> me if you approve.