Issue 2900008: Fix runtime JavaScript errors in chrome://options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2900008: Fix runtime JavaScript errors in chrome://options (Closed)

Created:
10 years, 5 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
mazda

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org, dhg, zel, James Hawkins

Visibility:
Public.

Description

Fix runtime JavaScript errors in chrome://options. With chrome built with CHROMEOS=1, the following error occurs in in chrome://options as sync-button and dummy-button don't exist. Remove the binding code to fix the error. [28843:28843:611993994873:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot set property 'onclick' of null," source: chrome://options/system (528) TEST=manually on ubuntu by "out/Release/chrome --test-type" BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52281

Patch Set 1 #

Patch Set 2 : remove instead of commenting out #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	chrome/browser/resources/options/chromeos_system_options.js	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

10 years, 5 months ago (2010-07-13 11:47:44 UTC) #3

Adding zelidrag and jhawkins just for FYI.

I was not able check this in today as the tree was closed all the day. Please
feel free to check this in on behalf of me if needed.

Expand Messages | Collapse Messages