Issue 2899014: Add login time metric for chromeos.

Issue 2899014: Add login time metric for chromeos. (Closed)

Created:
10 years, 5 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Nikita (slow), DaveMoore

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add login time metric for chromeos. TEST=Tested by gmerge chromeos-chrome onto device and checking about histograms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52411

Patch Set 3 : Change metric name #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
M	chrome/browser/chromeos/browser_notification_observers.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/browser_notification_observers.cc	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/google_authenticator.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

http://codereview.chromium.org/2899014/diff/2001/3001 File chrome/browser/chromeos/browser_notification_observers.cc (right): http://codereview.chromium.org/2899014/diff/2001/3001#newcode32 chrome/browser/chromeos/browser_notification_observers.cc:32: UMA_HISTOGRAM_TIMES("Chrome.LoginTime", BootTime.Login name suits better. It's not "boot time" ...

10 years, 5 months ago (2010-07-12 11:10:14 UTC) #2

sosa

10 years, 5 months ago (2010-07-12 18:44:24 UTC) #4

Changed metric name.  Dave, can you check this in for me (not a Chrome
committer)?  I just re-rebased against trunk.

http://codereview.chromium.org/2899014/diff/2001/3001
File chrome/browser/chromeos/browser_notification_observers.cc (right):

http://codereview.chromium.org/2899014/diff/2001/3001#newcode32
chrome/browser/chromeos/browser_notification_observers.cc:32:
UMA_HISTOGRAM_TIMES("Chrome.LoginTime",
On 2010/07/12 11:10:14, Nikita Kostylev wrote:
> BootTime.Login name suits better.
> 
> It's not "boot time" per se but it's a part of "boot time till web surfing is
> ready".
> 
> Looking at the other histograms in BootTime group seems that it would be
common
> case to see all of them together.
> 
> BootTime.Chrome
> BootTime.Firmware
> BootTime.Kernel
> BootTime.System
> BootTime.Total
> 
> Chrome seems like a group for some low-level stuff.

Done.

Expand Messages | Collapse Messages