Add signal handlers to ibus-chewing to listen for config changes.

Add signal handlers to ibus-chewing to listen for config changes.

BUG=chromium-os:4604
TEST=Enable ibus chewing.  Change the number of candidates in the chewing options dialog.  Check that the change has worked.

[satorux1, 2010-07-08 10:16:10]

http://codereview.chromium.org/2899003/diff/2001/3002
File src/IBusChewingEngine.gob (right):

http://codereview.chromium.org/2899003/diff/2001/3002#newcode793
src/IBusChewingEngine.gob:793: for (i=0;
propSpecs[i].valueType!=G_TYPE_INVALID;i++){
Could you write a comment what we are doing here?

http://codereview.chromium.org/2899003/diff/2001/3002#newcode1009
src/IBusChewingEngine.gob:1009: //self->config=ibus_config_new(iConnection);
Shouldn't we delete the unused code?

http://codereview.chromium.org/2899003/diff/2001/3002#newcode1014
src/IBusChewingEngine.gob:1014: self->handler_id =
g_signal_connect(self->config, "value-changed",
Could you write a comment why we should monitor this signal, and what we should
do upon the delivery of the signal?

[Zachary Kuznia, 2010-07-08 10:27:47]

http://codereview.chromium.org/2899003/diff/2001/3002
File src/IBusChewingEngine.gob (right):

http://codereview.chromium.org/2899003/diff/2001/3002#newcode793
src/IBusChewingEngine.gob:793: for (i=0;
propSpecs[i].valueType!=G_TYPE_INVALID;i++){
On 2010/07/08 10:16:10, satorux1 wrote:
> Could you write a comment what we are doing here?

Done.

http://codereview.chromium.org/2899003/diff/2001/3002#newcode1009
src/IBusChewingEngine.gob:1009: //self->config=ibus_config_new(iConnection);
Yes.  Done.

http://codereview.chromium.org/2899003/diff/2001/3002#newcode1014
src/IBusChewingEngine.gob:1014: self->handler_id =
g_signal_connect(self->config, "value-changed",
On 2010/07/08 10:16:10, satorux1 wrote:
> Could you write a comment why we should monitor this signal, and what we
should
> do upon the delivery of the signal?

Done.

[satorux1, 2010-07-08 10:33:49]

LGTM.

Could you upstream this?

On 2010/07/08 10:27:47, Zachary Kuznia wrote:
> http://codereview.chromium.org/2899003/diff/2001/3002
> File src/IBusChewingEngine.gob (right):
> 
> http://codereview.chromium.org/2899003/diff/2001/3002#newcode793
> src/IBusChewingEngine.gob:793: for (i=0;
> propSpecs[i].valueType!=G_TYPE_INVALID;i++){
> On 2010/07/08 10:16:10, satorux1 wrote:
> > Could you write a comment what we are doing here?
> 
> Done.
> 
> http://codereview.chromium.org/2899003/diff/2001/3002#newcode1009
> src/IBusChewingEngine.gob:1009: //self->config=ibus_config_new(iConnection);
> Yes.  Done.
> 
> http://codereview.chromium.org/2899003/diff/2001/3002#newcode1014
> src/IBusChewingEngine.gob:1014: self->handler_id =
> g_signal_connect(self->config, "value-changed",
> On 2010/07/08 10:16:10, satorux1 wrote:
> > Could you write a comment why we should monitor this signal, and what we
> should
> > do upon the delivery of the signal?
> 
> Done.

[Zachary Kuznia, 2010-07-09 01:23:51]

Certainly.

On 2010/07/08 10:33:49, satorux1 wrote:
> LGTM.
> 
> Could you upstream this?
> 
> On 2010/07/08 10:27:47, Zachary Kuznia wrote:
> > http://codereview.chromium.org/2899003/diff/2001/3002
> > File src/IBusChewingEngine.gob (right):
> > 
> > http://codereview.chromium.org/2899003/diff/2001/3002#newcode793
> > src/IBusChewingEngine.gob:793: for (i=0;
> > propSpecs[i].valueType!=G_TYPE_INVALID;i++){
> > On 2010/07/08 10:16:10, satorux1 wrote:
> > > Could you write a comment what we are doing here?
> > 
> > Done.
> > 
> > http://codereview.chromium.org/2899003/diff/2001/3002#newcode1009
> > src/IBusChewingEngine.gob:1009: //self->config=ibus_config_new(iConnection);
> > Yes.  Done.
> > 
> > http://codereview.chromium.org/2899003/diff/2001/3002#newcode1014
> > src/IBusChewingEngine.gob:1014: self->handler_id =
> > g_signal_connect(self->config, "value-changed",
> > On 2010/07/08 10:16:10, satorux1 wrote:
> > > Could you write a comment why we should monitor this signal, and what we
> > should
> > > do upon the delivery of the signal?
> > 
> > Done.