Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2897015: Clean up browser_resources.grd:... (Closed)

Created:
10 years, 5 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ncarter (slow), idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, Paul Godavari, Aaron Boodman, arv (Not doing code reviews), pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Clean up browser_resources.grd: * Flatten HTML where possible * Move resources only referenced by files in browser/resources/ into there (and out of the theme dir) * Remove duplicate/unreferenced resources * Remove IDs for resources that are inlined due to flattening * Remove IDR_CHAT_MANAGER_MANIFEST but leave the files on disk (they will be moving elsewhere some time soon) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -87 lines) Patch
D chrome/app/theme/checkbox_black.png View Binary file 0 comments Download
D chrome/app/theme/checkbox_white.png View Binary file 0 comments Download
D chrome/app/theme/closed_window.png View Binary file 0 comments Download
D chrome/app/theme/downloads_section.png View Binary file 0 comments Download
D chrome/app/theme/filebrowse_back.png View Binary file 0 comments Download
D chrome/app/theme/filebrowse_fullscreen.png View Binary file 0 comments Download
D chrome/app/theme/filebrowse_menu.png View Binary file 0 comments Download
D chrome/app/theme/history_section.png View Binary file 0 comments Download
D chrome/app/theme/icon_file.png View Binary file 0 comments Download
D chrome/app/theme/icon_folder.png View Binary file 0 comments Download
D chrome/app/theme/icon_media.png View Binary file 0 comments Download
D chrome/app/theme/icon_photo.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_full_screen.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_next.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_pause.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_play.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_playlist.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_prev.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_vol_high.png View Binary file 0 comments Download
D chrome/app/theme/mediaplayer_vol_mute.png View Binary file 0 comments Download
D chrome/app/theme/ntp_close.png View Binary file 0 comments Download
D chrome/app/theme/ntp_close_h.png View Binary file 0 comments Download
D chrome/app/theme/ntp_close_p.png View Binary file 0 comments Download
D chrome/app/theme/ntp_pin_off.png View Binary file 0 comments Download
D chrome/app/theme/ntp_pin_off_h.png View Binary file 0 comments Download
D chrome/app/theme/ntp_pin_off_p.png View Binary file 0 comments Download
D chrome/app/theme/ntp_pin_on.png View Binary file 0 comments Download
D chrome/app/theme/ntp_pin_on_h.png View Binary file 0 comments Download
D chrome/app/theme/ntp_pin_on_p.png View Binary file 0 comments Download
D chrome/app/theme/otr_icon_standalone.png View Binary file 0 comments Download
D chrome/app/theme/star_small.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 8 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/browser_resources.grd View 3 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/resources/about_memory.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/about_memory_linux.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/about_memory_mac.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/about_sys.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/app_gallery_icon.png View Binary file 0 comments Download
M chrome/browser/resources/downloads.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions_ui.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/filebrowse.html View 5 chunks +9 lines, -9 lines 0 comments Download
D chrome/browser/resources/gear.png View Binary file 0 comments Download
D chrome/browser/resources/gray.png View Binary file 0 comments Download
D chrome/browser/resources/help.gif View Binary file 0 comments Download
M chrome/browser/resources/history.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/history2.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/incognito_tab.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/media_common.js View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/resources/mediaplayer.html View 8 chunks +9 lines, -9 lines 0 comments Download
D chrome/browser/resources/minus.png View Binary file 0 comments Download
M chrome/browser/resources/new_new_tab.css View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/resources/ntp/checkbox_black.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/checkbox_white.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/closed_window.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/ntp/most_visited.css View 1 chunk +9 lines, -9 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_close.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_close_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_close_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_pin_off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_pin_off_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_pin_off_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_pin_on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_pin_on_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/ntp/ntp_pin_on_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/phishing_icon.png View Binary file 0 comments Download
M chrome/browser/resources/plugins.html View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/resources/plus.png View Binary file 0 comments Download
M chrome/browser/resources/safe_browsing_malware_block.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/safe_browsing_multiple_threat_block.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/safe_browsing_phishing_block.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/shared/images/downloads_section.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/filebrowse_back.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/filebrowse_fullscreen.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/filebrowse_menu.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/gear.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/help.gif View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/history_section.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/icon_file.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/icon_folder.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/icon_media.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/icon_photo.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_full_screen.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_next.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_pause.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_play.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_playlist.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_prev.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_vol_high.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/mediaplayer_vol_mute.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/minus.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/otr_icon_standalone.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/phishing_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/plus.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/images/star_small.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/js/media_common.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/slideshow.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/resources/about_sync.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/resources/gaia_login.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/sync/resources/gear.png View Binary file 0 comments Download
M chrome/renderer/resources/neterror.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
10 years, 5 months ago (2010-07-13 18:42:17 UTC) #1
arv (Not doing code reviews)
10 years, 5 months ago (2010-07-13 18:56:10 UTC) #2 
LGTM

Good luck

Powered by Google App Engine
This is Rietveld 408576698