Issue 2897004: Added strings for EULA wizard screen. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2897004: Added strings for EULA wizard screen. ... (Closed)

Created:
10 years, 5 months ago by glotov

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added strings for EULA wizard screen. Main change is here: http://codereview.chromium.org/2920001 BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51945

Patch Set 3 : '' #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1 2	1 chunk	+6 lines, -0 lines	2 comments	Download
	M	chrome/app/google_chrome_strings.grd	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

LGTM http://codereview.chromium.org/2897004/diff/5001/6001 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/2897004/diff/5001/6001#newcode7609 chrome/app/generated_resources.grd:7609: Continue >> Chevron symbol got lost.

10 years, 5 months ago (2010-07-08 20:27:20 UTC) #2

glotov

10 years, 5 months ago (2010-07-09 10:37:51 UTC) #3

Going to land the patch...

http://codereview.chromium.org/2897004/diff/5001/6001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2897004/diff/5001/6001#newcode7609
chrome/app/generated_resources.grd:7609: Continue >>
Thanx for catching it. Fixed.

On 2010/07/08 20:27:23, Nikita Kostylev wrote:
> Chevron symbol got lost.

Expand Messages | Collapse Messages

Issue 2897004: Added strings for EULA wizard screen. ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages