Issue 2896007: Fix a crash when using negotiate HTTP auth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2896007: Fix a crash when using negotiate HTTP auth. (Closed)

Created:
10 years, 5 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
cbentzel, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash when using negotiate HTTP auth. BUG=48690 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52025

Patch Set 1 #

Patch Set 2 : move below dcheck #

Patch Set 3 : Remove the NOTREACHED #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/io_thread.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eroman

I haven't tested this as I dont have setup for negotiate, but it shouldn't cause ...

10 years, 5 months ago (2010-07-09 23:32:16 UTC) #1

cbentzel

On 2010/07/09 23:38:50, wtc wrote: > LGTM. LGTM. Thanks a ton. I'll do more testing ...

10 years, 5 months ago (2010-07-10 00:11:29 UTC) #3

eroman

Wan-Teh tested this for me, and it seems to avoid the crash. Will check it ...

10 years, 5 months ago (2010-07-10 00:19:56 UTC) #4

eroman

10 years, 5 months ago (2010-07-10 00:21:33 UTC) #5

I have made a small update: removed the NOTREACHED() which I had added in the
first patchset.

(I actually prefer for us to hard crash if we hit this again in the future
rather than silently mask it.)

Expand Messages | Collapse Messages