Issue 2895008: Virtually dispatched specialized scavengers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2895008: Virtually dispatched specialized scavengers. (Closed)

Created:
10 years, 5 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Use virtually dispatched specialized scavengers instead of single generic ScavengeObjectSlow implementation. Committed: http://code.google.com/p/v8/source/detail?r=5041

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+348 lines, -151 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.h	View	3 chunks	+7 lines, -14 lines	0 comments	Download
M	src/heap.cc	View	9 chunks	+299 lines, -136 lines	1 comment	Download
M	src/objects.h	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/serialize.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 5 months ago (2010-07-12 11:32:12 UTC) #2

LGTM

http://codereview.chromium.org/2895008/diff/1/4
File src/heap.cc (right):

http://codereview.chromium.org/2895008/diff/1/4#newcode802
src/heap.cc:802: // A queue of pointers and maps of to-be-promoted objects
during a
This comment needs updating. The maps have been replaced by sizes.

Expand Messages | Collapse Messages