Issue 2893001: Clean up and simplify how we deal with filename extensions on Windows. Allow...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2893001: Clean up and simplify how we deal with filename extensions on Windows. Allow... (Closed)

Created:
10 years, 5 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Clean up and simplify how we deal with filename extensions on Windows. Allow users to use any name or extension they want, and only append the "desired" extension when the user's name doesn't have any known extension. Original patch by Jared Wein (see http://codereview.chromium.org/2825010 ), r=me. BUG=7499 TEST=Right-click on link, choose "Save link as...", leave the file type as the default but change the file name to have a different extension. Ensure that the browser doesn't append the original extension. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51870

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -33 lines)			Patch
M	chrome/browser/shell_dialogs.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/shell_dialogs_win.cc	View	1 chunk	+23 lines, -33 lines	0 comments	Download
A	chrome/browser/views/shell_dialogs_win_unittest.cc	View	1 chunk	+72 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download