Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2892007: Fix gclient.py so that save_pinned_deps works. (Closed)

Created:
10 years, 5 months ago by mazda
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, ctruta, satorux1, Jason Glasgow
Visibility:
Public.

Description

Fix gclient.py so that save_pinned_deps works. Chromium OS continuous builds are failing because of the following error. Traceback (most recent call last): File "/b/depot_tools/gclient.py", line 1212, in <module> sys.exit(Main(sys.argv[1:])) File "/b/depot_tools/gclient.py", line 1202, in Main return command(parser, argv[1:]) File "/b/depot_tools/gclient.py", line 1122, in CMDrevinfo client.PrintRevInfo() File "/b/depot_tools/gclient.py", line 776, in PrintRevInfo url = entries.pop(name) KeyError: 'chromiumos' This change will fix the error. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52180

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M gclient.py View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mazda
Hello Marc-Antoine, Can I ask you to review this change? I guess the three lines ...
10 years, 5 months ago (2010-07-13 11:09:56 UTC) #1
M-A Ruel
On 2010/07/13 11:09:56, mazda wrote: > Hello Marc-Antoine, > > Can I ask you to ...
10 years, 5 months ago (2010-07-13 15:36:35 UTC) #2
M-A Ruel
On 2010/07/13 11:09:56, mazda wrote: > Hello Marc-Antoine, > > Can I ask you to ...
10 years, 5 months ago (2010-07-13 15:36:59 UTC) #3
mazda
10 years, 5 months ago (2010-07-13 16:40:23 UTC) #4
On 2010/07/13 15:36:59, Marc-Antoine Ruel wrote:
> On 2010/07/13 11:09:56, mazda wrote:
> > Hello Marc-Antoine,
> > 
> > Can I ask you to review this change?
> > I guess the three lines were accidentally added in
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=52096
> > 
> > Thanks,
> 
> Sorry about that, hopefully this code will be deleted by the end of the week
but
> in the meantime lgtm.

Thanks, submitted.

Powered by Google App Engine
This is Rietveld 408576698