Issue 2891021: Privacy dashboard link for Mac. Only shown when --show-privacy-dashboard-lin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2891021: Privacy dashboard link for Mac. Only shown when --show-privacy-dashboard-lin... (Closed)

Created:
10 years, 5 months ago by John Gregg

Modified:
9 years ago

Reviewers:
akalin

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Privacy dashboard link for Mac. Only shown when --show-privacy-dashboard-link switch present. XIB changes: added a new link to the sync group of the preferences dialog (required adding a continuation array). Slightly altered the spacing to fit. BUG=48844 TEST=mac preferences pane with the above switch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52258

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+228 lines, -1016 lines)			Patch
M	chrome/app/nibs/Preferences.xib	View	82 chunks	+212 lines, -1016 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	3 chunks	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

akalin

10 years, 5 months ago (2010-07-13 23:06:09 UTC) #2

LGTM

http://codereview.chromium.org/2891021/diff/1/4
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/2891021/diff/1/4#newcode1763
chrome/browser/cocoa/preferences_window_controller.mm:1763: 
Add comment re. this leaving a space if there's no switch since there's no
dynamic layout.

Expand Messages | Collapse Messages