Issue 2891017: [gcc] Fix formatting issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2891017: [gcc] Fix formatting issues. (Closed)

Created:
10 years, 5 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@chromiumos-git/nacl-toolchain.git

Visibility:
Public.

Patch Set 2 : ready for code review #

Total comments: 4

Patch Set 3 : tiny whitespace fixes #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -127 lines)			Patch
	M	gcc/gcc/config/i386/i386.c	View		22 chunks	+106 lines, -107 lines	0 comments	Download
	M	gcc/gcc/config/i386/i386.md	View		12 chunks	+24 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pasko-google - do not use

http://codereview.chromium.org/2891017/diff/2001/3001 File gcc/gcc/config/i386/i386.c (left): http://codereview.chromium.org/2891017/diff/2001/3001#oldcode9181 gcc/gcc/config/i386/i386.c:9181: - * NaCl64. This may hurt when a symbol ...

10 years, 5 months ago (2010-07-13 12:21:56 UTC) #2

eaeltsin

Fixed. However, there are original coding style errors (original == not introduced by our patch). ...

10 years, 5 months ago (2010-07-13 12:45:26 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 2891017: [gcc] Fix formatting issues. (Closed)

Description

Patch Set 1 #

Patch Set 2 : ready for code review #

Patch Set 3 : tiny whitespace fixes #

Messages