Issue 2888025: Strip & accelerator markers from buttons on the Basics DOMUI pref page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2888025: Strip & accelerator markers from buttons on the Basics DOMUI pref page (Closed)

Created:
10 years, 5 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

Strip & accelerator markers from buttons on the Basics DOMUI pref page BUG=None TEST=Open DOMUI prefs; Add and Remove buttons on Basics page should not show &s. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53209

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

10 years, 5 months ago (2010-07-20 21:50:36 UTC) #2

LGTM

http://codereview.chromium.org/2888025/diff/1/2
File chrome/browser/resources/options/browser_options.js (right):

http://codereview.chromium.org/2888025/diff/1/2#newcode5
chrome/browser/resources/options/browser_options.js:5: //
nit/suggestion: change this comment to JSDoc style using @class keyword.

Expand Messages | Collapse Messages