Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5647)

Unified Diff: chrome/browser/cocoa/location_bar/autocomplete_text_field.mm

Issue 2888014: [Mac] Convert content settings to LocationBarDecoration, cleanup. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: noop change aiming for a clean try run. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
diff --git a/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm b/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
index 46b01d8269e550d38f43a98b55a2be916a9227be..041cff806eaf374061215dbca727308852edec9d 100644
--- a/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
+++ b/chrome/browser/cocoa/location_bar/autocomplete_text_field.mm
@@ -211,13 +211,10 @@
NSRect fieldBounds = [self bounds];
[self addCursorRect:fieldBounds cursor:[NSCursor IBeamCursor]];
- AutocompleteTextFieldCell* cell = [self cell];
- for (AutocompleteTextFieldIcon* icon in [cell layedOutIcons:fieldBounds])
- [self addCursorRect:[icon rect] cursor:[NSCursor arrowCursor]];
-
// TODO(shess): This needs to traverse the LocationBarDecorations
// and put up a cursor for them, too. Except for the keyword-search
// stuff? Sigh.
+ // http://crbug.com/48867
}
// TODO(shess): -resetFieldEditorFrameIfNeeded is the place where
@@ -236,6 +233,10 @@
[self removeAllToolTips];
[currentToolTips_ removeAllObjects];
+#if 0
+ // TODO(shess): Bring back tooltips. All the wiring is in there,
+ // just need to hook it up.
+ // http://crbug.com/49321
AutocompleteTextFieldCell* cell = [self cell];
for (AutocompleteTextFieldIcon* icon in [cell layedOutIcons:[self bounds]]) {
NSRect iconRect = [icon rect];
@@ -248,6 +249,7 @@
[currentToolTips_ addObject:tooltip];
[self addToolTipRect:iconRect owner:tooltip userData:nil];
}
+#endif
}
// NOTE(shess): http://crbug.com/19116 describes a weird bug which

Powered by Google App Engine
This is Rietveld 408576698