Issue 2888011: Allow maverick with install-build-deps.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2888011: Allow maverick with install-build-deps.sh. (Closed)

Created:
10 years, 5 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Allow maverick with install-build-deps.sh. The first time I ran it, I got an error and had to run apt-get install -f, then re-run install-build-deps.sh. I didn't write down the error so I don't think I can repro. It almost works, so perhaps the next person can copy down the error. http://src.chromium.org/viewvc/chrome?view=rev&revision=52563

Patch Set 1 #

Total comments: 1

Patch Set 2 : update text #

Patch Set 3 : long lines #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	build/install-build-deps.sh	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 5 months ago (2010-07-15 22:17:45 UTC) #2

LGTM

http://codereview.chromium.org/2888011/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/2888011/diff/1/2#newcode82
build/install-build-deps.sh:82: echo "Only Ubuntu 8.04 (hardy) through 10.04
(lucid) are currently supported" >&2
Update version here too

Expand Messages | Collapse Messages