Issue 2888: Fix http://code.google.com/p/v8/issues/detail?id=69 :...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2888: Fix http://code.google.com/p/v8/issues/detail?id=69 :... (Closed)

Created:
12 years, 3 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Feng Qian, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix http://code.google.com/p/v8/issues/detail?id=69 : - Simplify the switch statement code generation. - Ensure that the switch value is always popped from the stack. Credit goes to Feng for isolating the issue and proposing a fix. Committed: http://code.google.com/p/v8/source/detail?r=315

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -33 lines)			Patch
M	src/codegen-arm.cc	View	3 chunks	+21 lines, -17 lines	0 comments	Download
M	src/codegen-ia32.cc	View	3 chunks	+20 lines, -16 lines	0 comments	Download
A	test/mjsunit/regress/regress-69.js	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Kasper Lund

12 years, 3 months ago (2008-09-16 11:20:17 UTC) #2

LGTM. Maybe remove the 'var e' in the test case and change the --debug_code flag
to --debug-code?