Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2887009: Add kernel parameters for debugfs disable_*_ba values (Closed)

Created:
10 years, 5 months ago by Paul Stewart
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sleffler+cc_chromium.org, vb
Base URL:
ssh://gitrw.chromium.org/kernel.git
Visibility:
Public.

Description

Add kernel parameters to set default values for debugfs disable_*_ba values This provides a method for setting default values for the debugfs parameters for all phyNs at boot time, while continuing to allow runtime per-phy modifications. This is needed because debugfs parameters cannot easily be statically pushed onto a phy that may or may not yet be loaded, since an init script would have to mount the debugfs then monitor the directory until the phyN parameter appears. BUG=none TEST=rebooted with various config options

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chromeos/compat-wireless/net/mac80211/main.c View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paul Stewart
10 years, 5 months ago (2010-07-02 21:32:25 UTC) #1
Sam Leffler
LGTM please update the issue to explain that this is being done mostly because of ...
10 years, 5 months ago (2010-07-02 21:48:11 UTC) #2
Olof Johansson
Hi, Has this been posted for upstream, or will it be lost whenever we move ...
10 years, 5 months ago (2010-07-08 02:11:46 UTC) #3
Sam Leffler
It's likely to be a local patch for a while. We've got a handful of ...
10 years, 5 months ago (2010-07-08 02:15:43 UTC) #4
Paul Stewart
Could you clarify what should happen in order to create this "CHROMIUM:" prefix? I'm a ...
10 years, 5 months ago (2010-07-08 20:56:11 UTC) #5
Mandeep Singh Baines
Paul Stewart (pstew@chromium.org) wrote: > Could you clarify what should happen in order to create ...
10 years, 5 months ago (2010-07-08 23:16:28 UTC) #6
pstew1
10 years, 5 months ago (2010-07-09 00:00:53 UTC) #7
Thanks!

On Thu, Jul 8, 2010 at 4:16 PM, Mandeep Singh Baines <msb@chromium.org> wrote:
> Paul Stewart (pstew@chromium.org) wrote:
>> Could you clarify what should happen in order to create this
>> "CHROMIUM:" prefix?  I'm a relative newbie here.
>>
>
> http://dev.chromium.org/chromium-os/chromiumos-design-docs/chromium-os-kernel
>
>> --
>> Paul
>>
>> On Wed, Jul 7, 2010 at 7:11 PM,  <olofj@chromium.org> wrote:
>> > Hi,
>> >
>> > Has this been posted for upstream, or will it be lost whenever we move to a
>> > newer compat-wireless or base kernel?
>> >
>> > If it's local to chromeos and has to be carried forward manually, it should
>> > ideally be prefixed with CHROMIUM:, to not miss these cases.
>> >
>> > Also, adding a Signed-off-by is a good habit.
>> >
>> > http://codereview.chromium.org/2887009/show
>> >
>

Powered by Google App Engine
This is Rietveld 408576698