Issue 2887002: Fixed positions of label and border windows to avoid flickering on initial sh...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2887002: Fixed positions of label and border windows to avoid flickering on initial sh... (Closed)

Created:
10 years, 5 months ago by whywhat

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixed positions of label and border windows to avoid flickering on initial show of login screen. BUG=cros:4356 TEST=Verify that no white rectangles flicker near user pods on initial show. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51242

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -17 lines)			Patch
	M	chrome/browser/chromeos/login/user_controller.cc	View		5 chunks	+16 lines, -17 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

LGTM http://codereview.chromium.org/2887002/diff/5001/6001 File chrome/browser/chromeos/login/user_controller.cc (right): http://codereview.chromium.org/2887002/diff/5001/6001#newcode226 chrome/browser/chromeos/login/user_controller.cc:226: // submit_button_->SetEnabled(enable); Why is it here?

10 years, 5 months ago (2010-06-30 08:57:05 UTC) #2

whywhat

10 years, 5 months ago (2010-06-30 09:00:13 UTC) #3

http://codereview.chromium.org/2887002/diff/5001/6001
File chrome/browser/chromeos/login/user_controller.cc (right):

http://codereview.chromium.org/2887002/diff/5001/6001#newcode226
chrome/browser/chromeos/login/user_controller.cc:226: // 
submit_button_->SetEnabled(enable);
On 2010/06/30 08:57:05, Dmitry Polukhin wrote:
> Why is it here?

Forgot to uncomment. Done.

Expand Messages | Collapse Messages