Issue 2887001: Disable another crashing unload test on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2887001: Disable another crashing unload test on Linux (Closed)

Created:
10 years, 5 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
DO NOT USE THIS ACCOUNT

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Disable another crashing unload test on Linux TBR=erikkay BUG=47575 TEST=Greener bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51136

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/unload_uitest.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

erikkay

10 years, 5 months ago (2010-06-29 17:55:31 UTC) #2

LGTM

On Tue, Jun 29, 2010 at 10:15 AM, <stuartmorgan@chromium.org> wrote:

> Reviewers: erikkay,
>
> Description:
> Disable another crashing unload test on Linux
>
> TBR=erikkay
>
> BUG=47575
> TEST=Greener bots
>
> Please review this at http://codereview.chromium.org/2887001/show
>
> Affected files:
>  M chrome/browser/unload_uitest.cc
>
>
> Index: chrome/browser/unload_uitest.cc
> diff --git a/chrome/browser/unload_uitest.cc
> b/chrome/browser/unload_uitest.cc
> index
>
7ac65079e82ebbcc9ae39534feeef5874a72017e..04f2b5f6da6a18a34927638474c6dd4d7ecf39c2
> 100644
> --- a/chrome/browser/unload_uitest.cc
> +++ b/chrome/browser/unload_uitest.cc
> @@ -20,9 +20,13 @@
>  #define MAYBE_BrowserCloseNoUnloadListeners \
>         DISABLED_BrowserCloseNoUnloadListeners
>  #define MAYBE_BrowserCloseUnload DISABLED_BrowserCloseUnload
> +#define MAYBE_BrowserCloseTwoSecondBeforeUnload \
> +        DISABLED_BrowserCloseTwoSecondBeforeUnload
>  #else
>  #define MAYBE_BrowserCloseNoUnloadListeners BrowserCloseNoUnloadListeners
>  #define MAYBE_BrowserCloseUnload BrowserCloseUnload
> +#define MAYBE_BrowserCloseTwoSecondBeforeUnload \
> +        BrowserCloseTwoSecondBeforeUnload
>  #endif
>
>  const std::string NOLISTENERS_HTML =
> @@ -345,7 +349,7 @@ TEST_F(UnloadTest,
> MAYBE_BrowserCloseWithInnerFocusedFrame) {
>
>  // Tests closing the browser with a beforeunload handler that takes
>  // two seconds to run.
> -TEST_F(UnloadTest, BrowserCloseTwoSecondBeforeUnload) {
> +TEST_F(UnloadTest, MAYBE_BrowserCloseTwoSecondBeforeUnload) {
>   LoadUrlAndQuitBrowser(TWO_SECOND_BEFORE_UNLOAD_HTML,
>                         L"twosecondbeforeunload");
>  }
>
>
>

Expand Messages | Collapse Messages