notifications: Add a cross platform NotificationOptionsMenuModel that can be shared by the views and

notifications: Add a cross platform NotificationOptionsMenuModel that can be shared by the views and gtk frameworks.


BUG=None
TEST=Go to http://0xfe.muthanna.com/notifyme.html, request permission for notifications, notify it. Click on the wrench menu in the notification balloon, the menu should work as before.


Signed-off-by: Thiago Farina <tfarina@chromium.org>;

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52859

[tfarina, 2010-07-04 04:42:38]

Hi John, could you review this to me?

[tfarina, 2010-07-09 23:13:17]

Friendly ping.

[John Gregg, 2010-07-12 19:07:16]

On 2010/07/09 23:13:17, tfarina wrote:
> Friendly ping.

Thanks for this.  The code looks okay, but I was planning to move as much as
possible of the notifications options menu logic into cross platform code, with
adapters as needed for the different platforms, so a patch moving in that
direction would be better.

[tfarina, 2010-07-18 03:56:22]

On 2010/07/12 19:07:16, John Gregg wrote:
> On 2010/07/09 23:13:17, tfarina wrote:
> > Friendly ping.
> 
> Thanks for this.  The code looks okay, but I was planning to move as much as
> possible of the notifications options menu logic into cross platform code,
with
> adapters as needed for the different platforms, so a patch moving in that
> direction would be better.

Followed you suggestion and added a shared menu model that can be used by the
views too. Please, may you have another look?

[John Gregg, 2010-07-18 17:19:17]

On 2010/07/18 03:56:22, tfarina wrote:
> On 2010/07/12 19:07:16, John Gregg wrote:
> > On 2010/07/09 23:13:17, tfarina wrote:
> > > Friendly ping.
> > 
> > Thanks for this.  The code looks okay, but I was planning to move as much as
> > possible of the notifications options menu logic into cross platform code,
> with
> > adapters as needed for the different platforms, so a patch moving in that
> > direction would be better.
> 
> Followed you suggestion and added a shared menu model that can be used by the
> views too. Please, may you have another look?

Thanks, this looks good as a start.  LGTM to land and I will hook it up to the
other platforms in a separate patch

[tfarina, 2010-07-19 01:07:47]

On 2010/07/18 17:19:17, John Gregg wrote:
> Thanks, this looks good as a start.  LGTM to land and I will hook it up to the
> other platforms in a separate patch
John, this is in. I have windows box here and will do the views side in a follow
up patch.