Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2886010: Robustify package upgrades and dependency checking. (Closed)

Created:
10 years, 5 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

Robustify package upgrades and dependency checking. - Unmerge appropriate packages during upgrades and downgrades. - Calculate time spent in dependency generation to the tenth of a second. - Only track dependencies of packages that are actually being installed. - Ignore PDEPEND, as it has no impact on dependency ordering. - Only break dependency chains that go against Portage's install order. - Rename Failed -> Retrying. - Print emerge command lines as they are run. TEST=Emerged hard-host-depends and ran build_packages with parallel_emerge BUG=none

Patch Set 1 #

Total comments: 11

Patch Set 2 : Update to address review comments. #

Patch Set 3 : Fix stray tab #

Total comments: 8

Patch Set 4 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -57 lines) Patch
M parallel_emerge View 1 2 3 12 chunks +108 lines, -57 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidjames
10 years, 5 months ago (2010-07-01 23:27:35 UTC) #1
Nick Sanders
http://codereview.chromium.org/2886010/diff/1/2 File parallel_emerge (right): http://codereview.chromium.org/2886010/diff/1/2#newcode347 parallel_emerge:347: if pkg in deps_ordering: This will remove deps across ...
10 years, 5 months ago (2010-07-02 00:07:16 UTC) #2
davidjames
Thanks for the feedback. PTAL. http://codereview.chromium.org/2886010/diff/1/2 File parallel_emerge (right): http://codereview.chromium.org/2886010/diff/1/2#newcode347 parallel_emerge:347: if pkg in deps_ordering: ...
10 years, 5 months ago (2010-07-02 02:46:44 UTC) #3
Nick Sanders
lgtm w/ following http://codereview.chromium.org/2886010/diff/8001/9001 File parallel_emerge (right): http://codereview.chromium.org/2886010/diff/8001/9001#newcode461 parallel_emerge:461: # Store the dependency ordering stale ...
10 years, 5 months ago (2010-07-02 03:01:43 UTC) #4
davidjames
10 years, 5 months ago (2010-07-02 03:07:24 UTC) #5
Fixed. Will commit later after more testing.

http://codereview.chromium.org/2886010/diff/8001/9001
File parallel_emerge (right):

http://codereview.chromium.org/2886010/diff/8001/9001#newcode461
parallel_emerge:461: # Store the dependency ordering
On 2010/07/02 03:01:43, Nick Sanders wrote:
> stale

Done.

http://codereview.chromium.org/2886010/diff/8001/9001#newcode504
parallel_emerge:504: cmdline = cmdline = EmergeCommand() + " --nodeps --oneshot
=" + target
On 2010/07/02 03:01:43, Nick Sanders wrote:
> typo

Done.

http://codereview.chromium.org/2886010/diff/8001/9001#newcode507
parallel_emerge:507: emerge_cmd = "emerge"
On 2010/07/02 03:01:43, Nick Sanders wrote:
> Can we use included args to pickup any "-p" or "--root"

Done.

http://codereview.chromium.org/2886010/diff/8001/9001#newcode649
parallel_emerge:649: dependency_tree, dependency_ordering =
DepsToTree(deps_output)
On 2010/07/02 03:01:43, Nick Sanders wrote:
> also dependency_info 

Done.

Powered by Google App Engine
This is Rietveld 408576698