Issue 2886004: Disabling a layout test that started failing with the WebKit roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2886004: Disabling a layout test that started failing with the WebKit roll. (Closed)

Created:
10 years, 5 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Visibility:
Public.

Description

Disabling a layout test that started failing with the WebKit roll. TBR=ajwong@chromium.org TEST=Disabling a layout test momentarily. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51219

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

10 years, 5 months ago (2010-06-30 03:18:20 UTC) #2

LGTM

On Tue, Jun 29, 2010 at 8:17 PM, <levin@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Disabling a layout test that started failing with the WebKit roll.
>
> TBR=ajwong@chromium.org
> TEST=Disabling a layout test momentarily.
> BUG=None
>
> Please review this at http://codereview.chromium.org/2886004/show
>
> Affected files:
>  M webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> diff --git a/webkit/tools/layout_tests/test_expectations.txt
> b/webkit/tools/layout_tests/test_expectations.txt
> index
>
5124534bdd35c9a792688b0f968ed5c36c5abc3d..f8dea1795c5324f18a82e8c48314b54949fd2fae
> 100644
> --- a/webkit/tools/layout_tests/test_expectations.txt
> +++ b/webkit/tools/layout_tests/test_expectations.txt
> @@ -9,3 +9,6 @@ BUG47259 WIN : http/tests/local/blob/send-data-blob.html =
> TEXT
>
>  // I need to do a build on a Hardy box in order to get the baselines to
> agree.
>  LINUX BUG_AGL :
> platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html =
> IMAGE TEXT
> +
> +// Temp hack to disable this test failure due to a WebKit roll while I
> investigate it.
> +BUG_LEVIN : editing/pasteboard/5761530-1.html = TEXT
>
>
>

Expand Messages | Collapse Messages