Issue 2886002: NTP: Remove command line flag that allowed a local file to be used for the ne...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2886002: NTP: Remove command line flag that allowed a local file to be used for the ne... (Closed)

Created:
10 years, 5 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

NTP: Remove command line flag that allowed a local file to be used for the new tab page. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51204

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -43 lines)			Patch
M	chrome/browser/dom_ui/ntp_resource_cache.cc	View	2 chunks	+2 lines, -36 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

LGTM. Do we have a general bug out to refactor all the "new_new_tab_page" instances into ...

10 years, 5 months ago (2010-06-29 21:00:54 UTC) #2

arv (Not doing code reviews)

10 years, 5 months ago (2010-06-29 21:40:18 UTC) #3

re NTP: I started refactoring NTP and moving it into resources/ntp/

I'm fine renaming new_new_* to new_*

erik



On Tue, Jun 29, 2010 at 14:00,  <mirandac@chromium.org> wrote:
> LGTM.  Do we have a general bug out to refactor all the "new_new_tab_page"
> instances into "new_tab_page"?  (Especially considering I'm already getting
> emails about NNNTP, and we all know what happened with Roman numerals... :-)
>
> http://codereview.chromium.org/2886002/show
>

Expand Messages | Collapse Messages