src/x64/builtins-x64.cc - Issue 2885018: X64: Added register holding Smi::FromInt(1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 2885018: X64: Added register holding Smi::FromInt(1). (Closed)

Patch Set: Addressed review comments Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index ff655c76659aa174b52abd0655ee207b185d8d40..a38ebafc020b4747ee7c0eaa6ff4e853192a5b46 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -1238,10 +1238,6 @@ static void Generate_JSEntryTrampolineHelper(MacroAssembler* masm,

__ movq(rbx, r8);

#endif // _WIN64

- // Set up the roots register.

- ExternalReference roots_address = ExternalReference::roots_address();

- __ movq(kRootRegister, roots_address);

// Current stack contents:

// [rsp + 2 * kPointerSize ... ]: Internal frame

// [rsp + kPointerSize] : function

« no previous file with comments | « no previous file | src/x64/codegen-x64.cc » ('j') | no next file with comments »