Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2885005: Move chrome/common/net/notifier to jingle/notifier so that it can be used by remoting/remoting.gyp. (Closed)

Created:
10 years, 5 months ago by awong
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow), akalin
CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, idana, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, tim (not reviewing), Raghu Simha
Base URL:
git://codf21.jail.google.com/chromium.git
Visibility:
Public.

Description

Move chrome/common/net/notifier to jingle/notifier so that it can be used by remoting/remoting.gyp. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51216

Patch Set 1 #

Patch Set 2 : Fix one small bug #

Patch Set 3 : Update ifdefs #

Patch Set 4 : Add in the acutal build files #

Patch Set 5 : Add DEPS for include_headers and fix include order. #

Patch Set 6 : One more deps. Not passed checkdeps cleanly on my local box. #

Total comments: 3

Patch Set 7 : Style fixes from akalin. #

Patch Set 8 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -336 lines) Patch
M build/all.gyp View 10 chunks +18 lines, -17 lines 0 comments Download
A chrome/browser/sync/DEPS View 6 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/all_status.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/syncer_thread.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/DEPS View 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/server_notifier_thread.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/server_notifier_thread.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/tools/sync_tools.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 chunks +3 lines, -95 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
A chrome/service/cloud_print/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
A jingle/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A jingle/jingle.gyp View 1 chunk +139 lines, -0 lines 0 comments Download
A + jingle/notifier/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + jingle/notifier/base/signal_thread_task.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/base/sigslotrepeater.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/base/ssl_adapter.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/base/ssl_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + jingle/notifier/base/static_assert.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/base/task_pump.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/base/task_pump.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/communicator/auto_reconnect.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/communicator/auto_reconnect.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + jingle/notifier/communicator/connection_options.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/connection_options.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/communicator/connection_settings.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/connection_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/communicator/const_communicator.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/gaia_token_pre_xmpp_auth.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/gaia_token_pre_xmpp_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/communicator/login.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + jingle/notifier/communicator/login.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + jingle/notifier/communicator/login_connection_state.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/login_failure.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/login_failure.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/communicator/login_settings.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/communicator/login_settings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/product_info.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/product_info.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + jingle/notifier/communicator/single_login_attempt.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/communicator/single_login_attempt.cc View 1 chunk +10 lines, -10 lines 0 comments Download
A + jingle/notifier/communicator/ssl_socket_adapter.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/ssl_socket_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/communicator/xmpp_connection_generator.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/xmpp_connection_generator.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + jingle/notifier/communicator/xmpp_socket_adapter.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/communicator/xmpp_socket_adapter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/listen_task.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/listener/listen_task.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/mediator_thread.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/listener/mediator_thread_impl.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
A + jingle/notifier/listener/mediator_thread_impl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + jingle/notifier/listener/mediator_thread_mock.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/listener/notification_constants.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/notification_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/listener/notification_defines.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/send_update_task.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/listener/send_update_task.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/send_update_task_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + jingle/notifier/listener/subscribe_task.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/subscribe_task.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/subscribe_task_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + jingle/notifier/listener/talk_mediator.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + jingle/notifier/listener/talk_mediator_impl.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + jingle/notifier/listener/talk_mediator_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + jingle/notifier/listener/talk_mediator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/xml_element_util.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + jingle/notifier/listener/xml_element_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + jingle/notifier/listener/xml_element_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
awong
Fun fun fun.
10 years, 5 months ago (2010-06-29 18:48:03 UTC) #1
akalin
Don't you need DEPS changes from chrome/sync and whatever else uses notifier?
10 years, 5 months ago (2010-06-29 18:53:00 UTC) #2
awong
On 2010/06/29 18:53:00, akalin wrote: > Don't you need DEPS changes from chrome/sync and whatever ...
10 years, 5 months ago (2010-06-29 19:09:38 UTC) #3
akalin
10 years, 5 months ago (2010-06-29 19:13:05 UTC) #4 
LGTM

http://codereview.chromium.org/2885005/diff/14001/15002
File chrome/browser/sync/DEPS (right):

http://codereview.chromium.org/2885005/diff/14001/15002#newcode2
chrome/browser/sync/DEPS:2: # sync notifier depends on the common jingle
notifier classes.
sync notifier -> sync_notifier

http://codereview.chromium.org/2885005/diff/14001/15006
File chrome/browser/sync/notifier/DEPS (right):

http://codereview.chromium.org/2885005/diff/14001/15006#newcode6
chrome/browser/sync/notifier/DEPS:6: # sync notifier depends on the common
jingle notifier classes.
Move this above talk/xmpp to be in alphabetical order.

http://codereview.chromium.org/2885005/diff/14001/15006#newcode6
chrome/browser/sync/notifier/DEPS:6: # sync notifier depends on the common
jingle notifier classes.
sync notifier -> sync_notifier

Powered by Google App Engine
This is Rietveld 408576698