Issue 2885004: Linux: Blind fix for npwrapper crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2885004: Linux: Blind fix for npwrapper crashes. (Closed)

Created:
10 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
jam, Evan Martin

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: Blind fix for npwrapper crashes. BUG=47796 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51299

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	webkit/glue/plugins/plugin_host.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

This is vaguely familiar... oh yeah, this one: http://code.google.com/p/chromium/issues/detail?id=39917 I kinda wonder if we should ...

10 years, 5 months ago (2010-06-29 01:21:32 UTC) #2

jam

10 years, 5 months ago (2010-06-29 21:59:36 UTC) #3

On 2010/06/29 01:21:32, Evan Martin wrote:
> This is vaguely familiar... oh yeah, this one:
> http://code.google.com/p/chromium/issues/detail?id=39917
> 
> I kinda wonder if we should handle FindInstance failing in some general way. 
> Maybe normally we shut down plugins such that FindInstance should never fail? 
> John would know!

This shouldn't really be happening..  If there's a repro case, I can look into
it..  but for now this fix seems ok

Expand Messages | Collapse Messages