Issue 2884060: cros_mark_as_stable: add a --srcroot command-line option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2884060: cros_mark_as_stable: add a --srcroot command-line option (Closed)

Created:
10 years, 4 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
petkov, sosa

CC:
chromium-os-reviews_chromium.org, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

cros_mark_as_stable: add a --srcroot command-line option This is required to enable running cros_mark_as_stable from outside the chroot. BUG=5258 TEST=Successfully ran outside the chroot and pushed a change. All unit tests continue to pass. Change-Id: Ibd23ace6326b8453c132c416d6db6e42c8c2c239

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	cros_mark_as_stable.py	View		7 chunks	+11 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM if you update the option description http://codereview.chromium.org/2884060/diff/1/2 File cros_mark_as_stable.py (right): http://codereview.chromium.org/2884060/diff/1/2#newcode37 cros_mark_as_stable.py:37: 'Used with ...

10 years, 4 months ago (2010-08-02 18:35:23 UTC) #2

Mandeep Singh Baines

10 years, 4 months ago (2010-08-02 18:49:33 UTC) #3

On 2010/08/02 18:35:23, petkov wrote:
> LGTM if you update the option description
> 

D'oh. Fixed and committed.

> http://codereview.chromium.org/2884060/diff/1/2
> File cros_mark_as_stable.py (right):
> 
> http://codereview.chromium.org/2884060/diff/1/2#newcode37
> cros_mark_as_stable.py:37: 'Used with commit to specify branch to track
> against.',
> Update option description.
> 
> http://codereview.chromium.org/2884060/diff/1/2#newcode332
> cros_mark_as_stable.py:332: 
> no need for blank line, i think

Expand Messages | Collapse Messages