Issue 2884040: Rename ExternalProtocolHandler::OnUserGesture -> PermitLaunchUrl & call from EFD::HandleRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2884040: Rename ExternalProtocolHandler::OnUserGesture -> PermitLaunchUrl & call from EFD::HandleRequest (Closed)

Created:
10 years, 5 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Rename ExternalProtocolHandler::OnUserGesture -> PermitLaunchUrl & call from EFD::HandleRequest. Extension functions should be allowed to make repeat requests to external protocol handling without needing a user gesture (see bug). This allows them to do so (and changes the method name for clarity). BUG=39178 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53846

Patch Set 1 #

Total comments: 1

Patch Set 2 : cr changes #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/external_protocol_handler.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/external_protocol_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

http://codereview.chromium.org/2884040/diff/1/2 File chrome/browser/extensions/extension_function_dispatcher.cc (right): http://codereview.chromium.org/2884040/diff/1/2#newcode417 chrome/browser/extensions/extension_function_dispatcher.cc:417: // APIs to fire repeated external protocol handlers. See ...

10 years, 5 months ago (2010-07-26 23:21:13 UTC) #2

rafaelw

10 years, 5 months ago (2010-07-27 00:01:44 UTC) #3

renamed to PermitLaunchUrl

(rubber-stamp lgtm from pkasting on gtalk).

Expand Messages | Collapse Messages