Issue 2884016: Chrome side of Pepper v2 scrollbar widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2884016: Chrome side of Pepper v2 scrollbar widget. (Closed)

Created:
10 years, 5 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Chrome side of Pepper v2 scrollbar widget. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51818

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+727 lines, -101 lines)			Patch
M	chrome/renderer/pepper_scrollbar_widget.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	webkit/glue/plugins/pepper_event_conversion.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_event_conversion.cc	View		1 chunk	+235 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.cc	View		4 chunks	+9 lines, -99 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_module.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_scrollbar.h	View	1	1 chunk	+64 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_scrollbar.cc	View	1	1 chunk	+228 lines, -0 lines	1 comment	Download
A	webkit/glue/plugins/pepper_widget.h	View		1 chunk	+53 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_widget.cc	View		1 chunk	+90 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 5 months ago (2010-07-07 03:43:31 UTC) #2

LGTM

http://codereview.chromium.org/2884016/diff/13001/8008
File webkit/glue/plugins/pepper_scrollbar.cc (right):

http://codereview.chromium.org/2884016/diff/13001/8008#newcode98
webkit/glue/plugins/pepper_scrollbar.cc:98:
static_cast<WebKit::WebScrollbarClient*>(this),
These should be indented 2 more spaces.

Expand Messages | Collapse Messages