Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: src/builtins-arm.cc

Issue 2884: Stop adapting the arguments passed to the builtin implementations... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/builtins-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins-arm.cc
===================================================================
--- src/builtins-arm.cc (revision 311)
+++ src/builtins-arm.cc (working copy)
@@ -40,12 +40,21 @@
void Builtins::Generate_Adaptor(MacroAssembler* masm,
int argc,
CFunctionId id) {
- // r0 contains the number of arguments excluding the receiver.
- // JumpToBuiltin expects r0 to contains the number of arguments
- // including the receiver.
- __ mov(r0, Operand(argc + 1));
+ // TODO(1238487): Don't pass the function in a static variable.
__ mov(ip, Operand(ExternalReference::builtin_passed_function()));
__ str(r1, MemOperand(ip, 0));
+
+ if (argc == -1) {
+ // The actual argument count has already been loaded into register
+ // r0, but JumpToBuiltin expects r0 to contain the number of
+ // arguments including the receiver.
+ __ add(r0, r0, Operand(1));
+ } else {
+ // The number passed in argc excludes the receiver, but
+ // JumpToBuiltin expects r0 to contain the number of arguments
+ // including the receiver.
+ __ mov(r0, Operand(argc + 1));
+ }
__ JumpToBuiltin(ExternalReference(id));
}
« no previous file with comments | « src/builtins.cc ('k') | src/builtins-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698