Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2884: Stop adapting the arguments passed to the builtin implementations... (Closed)

Created:
12 years, 3 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Stop adapting the arguments passed to the builtin implementations of Array.prototype.push and Array.prototype.pop. Avoid going through the arguments adaptor trampoline for call ICs that end up calling a builtin that does not need arguments adaption. Committed: http://code.google.com/p/v8/source/detail?r=312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -44 lines) Patch
M src/bootstrapper.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 7 chunks +15 lines, -21 lines 0 comments Download
M src/builtins-arm.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M src/builtins-ia32.cc View 1 chunk +15 lines, -6 lines 0 comments Download
M src/macro-assembler-arm.cc View 1 chunk +10 lines, -1 line 0 comments Download
M src/macro-assembler-ia32.cc View 1 chunk +10 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
12 years, 3 months ago (2008-09-16 07:10:52 UTC) #1
Mads Ager (chromium)
12 years, 3 months ago (2008-09-16 07:23:33 UTC) #2
This looks great to me!

Powered by Google App Engine
This is Rietveld 408576698