Issue 2883057: Add debuggin CHECK to help track down ExtensionHost crasher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2883057: Add debuggin CHECK to help track down ExtensionHost crasher (Closed)

Created:
10 years, 4 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add debuggin CHECK to help track down ExtensionHost crasher Hopefully this well tells us whether it's the ExtensionHost that has been deleted. BUG=49114 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55097

Patch Set 1 #

Patch Set 2 : add recently_deleted list #

Total comments: 2

Patch Set 3 : cr comment #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
M	chrome/browser/extensions/extension_host.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	1	1 chunk	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

LGTM http://codereview.chromium.org/2883057/diff/3001/4001 File chrome/browser/extensions/extension_host.cc (right): http://codereview.chromium.org/2883057/diff/3001/4001#newcode160 chrome/browser/extensions/extension_host.cc:160: if (recently_deleted()->size() == 20) nit: >= 20 just ...

10 years, 4 months ago (2010-08-05 17:56:01 UTC) #3

rafaelw

10 years, 4 months ago (2010-08-05 18:04:56 UTC) #4

http://codereview.chromium.org/2883057/diff/3001/4001
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/2883057/diff/3001/4001#newcode160
chrome/browser/extensions/extension_host.cc:160: if (recently_deleted()->size()
== 20)
On 2010/08/05 17:56:02, Matt Perry wrote:
> nit: >= 20 just to be paranoid

Done.

Expand Messages | Collapse Messages