Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: test/cctest/test-debug.cc

Issue 2883042: Breakpoint position should be inside function body. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2007-2008 the V8 project authors. All rights reserved. 1 // Copyright 2007-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1157 matching lines...) Expand 10 before | Expand all | Expand 10 after
1168 1168
1169 // Run without breakpoints. 1169 // Run without breakpoints.
1170 foo->Call(env->Global(), 0, NULL); 1170 foo->Call(env->Global(), 0, NULL);
1171 CHECK_EQ(0, break_point_hit_count); 1171 CHECK_EQ(0, break_point_hit_count);
1172 1172
1173 // Run with breakpoint 1173 // Run with breakpoint
1174 int bp = SetBreakPoint(foo, 0); 1174 int bp = SetBreakPoint(foo, 0);
1175 foo->Call(env->Global(), 0, NULL); 1175 foo->Call(env->Global(), 0, NULL);
1176 CHECK_EQ(1, break_point_hit_count); 1176 CHECK_EQ(1, break_point_hit_count);
1177 CHECK_EQ(0, last_source_line); 1177 CHECK_EQ(0, last_source_line);
1178 CHECK_EQ(16, last_source_column); 1178 CHECK_EQ(15, last_source_column);
1179 foo->Call(env->Global(), 0, NULL); 1179 foo->Call(env->Global(), 0, NULL);
1180 CHECK_EQ(2, break_point_hit_count); 1180 CHECK_EQ(2, break_point_hit_count);
1181 CHECK_EQ(0, last_source_line); 1181 CHECK_EQ(0, last_source_line);
1182 CHECK_EQ(16, last_source_column); 1182 CHECK_EQ(15, last_source_column);
1183 1183
1184 // Run without breakpoints. 1184 // Run without breakpoints.
1185 ClearBreakPoint(bp); 1185 ClearBreakPoint(bp);
1186 foo->Call(env->Global(), 0, NULL); 1186 foo->Call(env->Global(), 0, NULL);
1187 CHECK_EQ(2, break_point_hit_count); 1187 CHECK_EQ(2, break_point_hit_count);
1188 1188
1189 v8::Debug::SetDebugEventListener(NULL); 1189 v8::Debug::SetDebugEventListener(NULL);
1190 CheckDebuggerUnloaded(); 1190 CheckDebuggerUnloaded();
1191 } 1191 }
1192 1192
(...skipping 5516 matching lines...) Expand 10 before | Expand all | Expand 10 after
6709 6709
6710 CHECK_EQ(2, TestClientData::constructor_call_counter); 6710 CHECK_EQ(2, TestClientData::constructor_call_counter);
6711 CHECK_EQ(TestClientData::constructor_call_counter, 6711 CHECK_EQ(TestClientData::constructor_call_counter,
6712 TestClientData::destructor_call_counter); 6712 TestClientData::destructor_call_counter);
6713 6713
6714 v8::Debug::SetDebugEventListener(NULL); 6714 v8::Debug::SetDebugEventListener(NULL);
6715 CheckDebuggerUnloaded(); 6715 CheckDebuggerUnloaded();
6716 } 6716 }
6717 6717
6718 #endif // ENABLE_DEBUGGER_SUPPORT 6718 #endif // ENABLE_DEBUGGER_SUPPORT
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698