Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Side by Side Diff: src/full-codegen.cc

Issue 2883042: Breakpoint position should be inside function body. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 752 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 763
764 void FullCodeGenerator::SetFunctionPosition(FunctionLiteral* fun) { 764 void FullCodeGenerator::SetFunctionPosition(FunctionLiteral* fun) {
765 if (FLAG_debug_info) { 765 if (FLAG_debug_info) {
766 CodeGenerator::RecordPositions(masm_, fun->start_position()); 766 CodeGenerator::RecordPositions(masm_, fun->start_position());
767 } 767 }
768 } 768 }
769 769
770 770
771 void FullCodeGenerator::SetReturnPosition(FunctionLiteral* fun) { 771 void FullCodeGenerator::SetReturnPosition(FunctionLiteral* fun) {
772 if (FLAG_debug_info) { 772 if (FLAG_debug_info) {
773 CodeGenerator::RecordPositions(masm_, fun->end_position()); 773 CodeGenerator::RecordPositions(masm_, fun->end_position() - 1);
Peter Rybin 2010/07/28 13:00:14 Theoretically, you may consider creating a named c
774 } 774 }
775 } 775 }
776 776
777 777
778 void FullCodeGenerator::SetStatementPosition(Statement* stmt) { 778 void FullCodeGenerator::SetStatementPosition(Statement* stmt) {
779 if (FLAG_debug_info) { 779 if (FLAG_debug_info) {
780 #ifdef ENABLE_DEBUGGER_SUPPORT 780 #ifdef ENABLE_DEBUGGER_SUPPORT
781 if (!Debugger::IsDebuggerActive()) { 781 if (!Debugger::IsDebuggerActive()) {
782 CodeGenerator::RecordPositions(masm_, stmt->statement_pos()); 782 CodeGenerator::RecordPositions(masm_, stmt->statement_pos());
783 } else { 783 } else {
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
1434 // The macros used here must preserve the result register. 1434 // The macros used here must preserve the result register.
1435 __ Drop(stack_depth); 1435 __ Drop(stack_depth);
1436 __ PopTryHandler(); 1436 __ PopTryHandler();
1437 return 0; 1437 return 0;
1438 } 1438 }
1439 1439
1440 #undef __ 1440 #undef __
1441 1441
1442 1442
1443 } } // namespace v8::internal 1443 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698