Issue 2883042: Breakpoint position should be inside function body.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2883042: Breakpoint position should be inside function body. (Closed)

Created:
10 years, 4 months ago by podivilov

Modified:
9 years, 3 months ago

Reviewers:
Søren Thygesen Gjesse, Peter Rybin

CC:
v8-dev

Visibility:
Public.

Description

Breakpoint position should be inside function body. Committed: http://code.google.com/p/v8/source/detail?r=5145

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -28 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/debug.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/debug-breakpoints.js	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	test/mjsunit/debug-conditional-breakpoints.js	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	test/mjsunit/debug-return-value.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

10 years, 4 months ago (2010-07-28 13:00:14 UTC) #3

http://codereview.chromium.org/2883042/diff/1/5
File src/full-codegen.cc (right):

http://codereview.chromium.org/2883042/diff/1/5#newcode773
src/full-codegen.cc:773: CodeGenerator::RecordPositions(masm_,
fun->end_position() - 1);
Theoretically, you may consider creating a named constant for this "-1".

Expand Messages | Collapse Messages