Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2883035: Add Dependency.hierarchy() to better visualize the origin of a dependency. (Closed)

Created:
10 years, 5 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, bmcquade1
Visibility:
Public.

Description

Add Dependency.hierarchy() to better visualize the origin of a dependency. TBR=bradnelson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53379

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M gclient.py View 2 chunks +14 lines, -3 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
It gives a better idea of what is going wrong in the code. No code ...
10 years, 5 months ago (2010-07-22 20:58:12 UTC) #1
bradn
10 years, 5 months ago (2010-07-22 21:22:25 UTC) #2
http://codereview.chromium.org/2883035/diff/2001/3001
File gclient.py (right):

http://codereview.chromium.org/2883035/diff/2001/3001#newcode442
gclient.py:442: "Returns a human-readable hierarchical reference to a
Dependency."
Uh you'll want a """ here I believe.

Powered by Google App Engine
This is Rietveld 408576698