Issue 2883020: Describe LiveEdit changes and support preview mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2883020: Describe LiveEdit changes and support preview mode (Closed)

Created:
10 years, 5 months ago by Peter Rybin

Modified:
7 years, 6 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Visibility:
Public.

Description

Describe LiveEdit changes and support preview mode Committed: http://code.google.com/p/v8/source/detail?r=5015

Patch Set 2 : rollback something #

Patch Set 4 : drop old function #

Patch Set 6 : follow codereview #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -43 lines)			Patch
M	src/debug-debugger.js	View	1	2 chunks	+4 lines, -12 lines	0 comments	Download
M	src/liveedit-debugger.js	View	1 2 3 4 5	16 chunks	+141 lines, -28 lines	0 comments	Download
M	test/mjsunit/debug-liveedit-3.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/debug-liveedit-breakpoints.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/debug-liveedit-newsource.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

LGTM with comments http://codereview.chromium.org/2883020/diff/9001/10002 File src/liveedit-debugger.js (right): http://codereview.chromium.org/2883020/diff/9001/10002#newcode54 src/liveedit-debugger.js:54: function ApplyPatchMultiChunk(script, diff_array, new_source, preview_only, change_log) ...

10 years, 5 months ago (2010-07-02 16:23:36 UTC) #3

Peter Rybin

7 years, 6 months ago (2013-06-26 19:39:57 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/2883020/diff/9001/src/liveedit-debugger.js
File src/liveedit-debugger.js (right):

https://codereview.chromium.org/2883020/diff/9001/src/liveedit-debugger.js#ne...
src/liveedit-debugger.js:54: function ApplyPatchMultiChunk(script, diff_array,
new_source, preview_only, change_log) {
On 2010/07/02 16:23:36, Michail Naganov wrote:
> nit: >80 chars

Done.

https://codereview.chromium.org/2883020/diff/9001/src/liveedit-debugger.js#ne...
src/liveedit-debugger.js:867: return;
On 2010/07/02 16:23:36, Michail Naganov wrote:
> I would expect a comment here.

Done.