Issue 2883012: cros_workon: quick hack at package name checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2883012: cros_workon: quick hack at package name checking (Closed)

Created:
10 years, 5 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
zbehan, sosa, davidjames

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

cros_workon: quick hack at package name checking Change-Id: I30e97760d5b96077e38414be31ef434542021361

Patch Set 1 #

Patch Set 2 : Send again. #

Total comments: 3

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	cros_workon	View		1 chunk	+20 lines, -0 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 5 months ago (2010-07-01 17:44:07 UTC) #3

lgtm with a cpl nits

http://codereview.chromium.org/2883012/diff/3001/4001
File cros_workon (right):

http://codereview.chromium.org/2883012/diff/3001/4001#newcode50
cros_workon:50: equery-${FLAGS_board} which $1 | \
If only equery list could do this with an option it would make scripting much
cleaner :D

http://codereview.chromium.org/2883012/diff/3001/4001#newcode54
cros_workon:54: # Canonicalize a list of names
Period at end.

http://codereview.chromium.org/2883012/diff/3001/4001#newcode57
cros_workon:57: local names
Prefer if you explicitly set names  to ""

Expand Messages | Collapse Messages