Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2882004: Added support for allowing a parent GGL context to be destroyed before all of... (Closed)

Created:
10 years, 5 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
Vangelis Kokkevis
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Added support for allowing a parent GGL context to be destroyed before all of its children. I made the parent_ pointer a WeakPtr. It is correct to not free the offscreen texture ID if the parent is destroyed first. It is freed as part of the parent's destruction. TEST=trybot BUG=47594 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/renderer/ggl/ggl.cc View 7 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick_chromium
10 years, 5 months ago (2010-06-28 22:26:41 UTC) #1
Vangelis Kokkevis
10 years, 5 months ago (2010-06-29 17:15:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698