Issue 2881007: Roll back change list 2838024.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2881007: Roll back change list 2838024. (Closed)

Created:
10 years, 5 months ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Roll back change list 2838024. The current autotest ebuild cros_workon change takes more time than I expected, so I had to roll back this change to enforce autotest prebuild on buildbot. As of now, the prebuild autotest tarball has no binaries produced within it.

Patch Set 1 #

Patch Set 2 : patch #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	autotest	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ericli

Once autotest ebuild cros_workon is working, eventually we will retire build_autotest.sh + autotest.

10 years, 5 months ago (2010-07-01 03:17:00 UTC) #1

sosa

10 years, 5 months ago (2010-07-01 03:43:27 UTC) #2

LGTM

On Wed, Jun 30, 2010 at 8:17 PM,  <ericli@chromium.org> wrote:
> Reviewers: sosa,
>
> Message:
> Once autotest ebuild cros_workon is working, eventually we will retire
> build_autotest.sh + autotest.
>
> Description:
> Roll back change list 2838024.
>
> The current autotest ebuild cros_workon change takes more time than I
> expected,
> so I had to roll back this change to enforce autotest prebuild on buildbot.
>
> As of now, the prebuild autotest tarball has no binaries produced within it.
>
> Please review this at http://codereview.chromium.org/2881007/show
>
> SVN Base: ssh://git@chromiumos-git/crosutils.git
>
> Affected files:
>  M autotest
>
>
> Index: autotest
> diff --git a/autotest b/autotest
> index
>
823ea91c33f7408cc877bf4f2e7e9c317d5c46fe..1ab04e3083485d3dfb11dfe88170acdb501ad839
> 100755
> --- a/autotest
> +++ b/autotest
> @@ -185,7 +185,6 @@ def build_autotest(options):
>   environ['TEST_LIST'] = test_list
>   environ['USE'] = use_flag
>   emerge_cmd = ['emerge-%s' % options.board,
> -                '-uDn',
>                 'chromeos-base/autotest']
>   if emerge_jobs:
>     emerge_cmd.append(emerge_jobs)
>
>
>

Expand Messages | Collapse Messages