Issue 2881006: GTK: Add padding in a couple places on the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2881006: GTK: Add padding in a couple places on the toolbar. (Closed)

Created:
10 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

GTK: Add padding in a couple places on the toolbar. -To the right of the star (inside the URL entry): add 2 pixels. -Between the tabstrip and window controls: add 16 pixels (only when using the custom frame and the window is maximized). BUG=47487 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51474

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -14 lines)			Patch
	M	chrome/browser/gtk/browser_titlebar.cc	View		2 chunks	+25 lines, -11 lines	1 comment	Download
	M	chrome/browser/gtk/location_bar_view_gtk.cc	View		2 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

10 years, 5 months ago (2010-07-01 05:04:12 UTC) #2

LGTM

http://codereview.chromium.org/2881006/diff/1/2
File chrome/browser/gtk/browser_titlebar.cc (right):

http://codereview.chromium.org/2881006/diff/1/2#newcode507
chrome/browser/gtk/browser_titlebar.cc:507: left_padding = side_padding;
Heh, I bet this looks kind of weird with buttons on both sides.

Expand Messages | Collapse Messages