Cleaning up SPDY unit tests

Refactors SPDY frame construction methods out of
spdy_network_transaction_unittest.cc
to promote code reuse. Removes the kGetSyn and kGetSynReply binary
SPDY frame constants and replaces them with calls to factory methods,
for better clarity and to reduce maintenance costs going forward.
Also adds some helper methods for constructing mock reads and writes
from SpdyFrames.

TEST=net_unittests pass.
BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51049

[Mike Belshe, 2010-06-25 20:26:40]

All nits - lgtm

http://codereview.chromium.org/2881001/diff/1/4
File net/spdy/spdy_test_util.cc (right):

http://codereview.chromium.org/2881001/diff/1/4#newcode10
net/spdy/spdy_test_util.cc:10: #include "net/base/completion_callback.h"
nit: don't need this?  can you take a pass through and prune out the unnecessary
includes?

http://codereview.chromium.org/2881001/diff/1/4#newcode133
net/spdy/spdy_test_util.cc:133: // Returns a SpdFrame.
typo

http://codereview.chromium.org/2881001/diff/1/5
File net/spdy/spdy_test_util.h (right):

http://codereview.chromium.org/2881001/diff/1/5#newcode89
net/spdy/spdy_test_util.h:89: int kind;
nit:  while you're here could you document a few of these?  I can never remember
what "kind" is without looking deeper :-)

Maybe this is supposed to be a SpdyControlType ?

http://codereview.chromium.org/2881001/diff/1/5#newcode126
net/spdy/spdy_test_util.h:126: int AppendToBuffer(const void* str,
nit:  can we use a const char* here?

http://codereview.chromium.org/2881001/diff/1/5#newcode130
net/spdy/spdy_test_util.h:130: if (len <= 0)
nit: DCHECK_GE(len, 0);

http://codereview.chromium.org/2881001/diff/1/5#newcode159
net/spdy/spdy_test_util.h:159: // Returns a SpdFrame.
typo: SpdyFrame

http://codereview.chromium.org/2881001/diff/1/5#newcode206
net/spdy/spdy_test_util.h:206: // Create a MockWrite from the given SpdyFrame.
nit:  "Create an async MockWrite..."

[Matthew Lloyd, 2010-06-25 20:43:49]

Thanks for the prompt review. All done.

http://codereview.chromium.org/2881001/diff/1/4
File net/spdy/spdy_test_util.cc (right):

http://codereview.chromium.org/2881001/diff/1/4#newcode10
net/spdy/spdy_test_util.cc:10: #include "net/base/completion_callback.h"
On 2010/06/25 20:26:40, Mike Belshe wrote:
> nit: don't need this?  can you take a pass through and prune out the
unnecessary
> includes?

Done.

http://codereview.chromium.org/2881001/diff/1/4#newcode133
net/spdy/spdy_test_util.cc:133: // Returns a SpdFrame.
On 2010/06/25 20:26:40, Mike Belshe wrote:
> typo

Done.

http://codereview.chromium.org/2881001/diff/1/5
File net/spdy/spdy_test_util.h (right):

http://codereview.chromium.org/2881001/diff/1/5#newcode89
net/spdy/spdy_test_util.h:89: int kind;
On 2010/06/25 20:26:40, Mike Belshe wrote:
> nit:  while you're here could you document a few of these?  I can never
remember
> what "kind" is without looking deeper :-)
> 
> Maybe this is supposed to be a SpdyControlType ?

Even better - I changed the types to the appropriate enums.

http://codereview.chromium.org/2881001/diff/1/5#newcode126
net/spdy/spdy_test_util.h:126: int AppendToBuffer(const void* str,
On 2010/06/25 20:26:40, Mike Belshe wrote:
> nit:  can we use a const char* here? 

Done.

http://codereview.chromium.org/2881001/diff/1/5#newcode130
net/spdy/spdy_test_util.h:130: if (len <= 0)
On 2010/06/25 20:26:40, Mike Belshe wrote:
> nit: DCHECK_GE(len, 0);

Done.

http://codereview.chromium.org/2881001/diff/1/5#newcode159
net/spdy/spdy_test_util.h:159: // Returns a SpdFrame.
On 2010/06/25 20:26:40, Mike Belshe wrote:
> typo: SpdyFrame

Done.

http://codereview.chromium.org/2881001/diff/1/5#newcode206
net/spdy/spdy_test_util.h:206: // Create a MockWrite from the given SpdyFrame.
On 2010/06/25 20:26:40, Mike Belshe wrote:
> nit:  "Create an async MockWrite..."

Done.