chrome/browser/dom_ui/downloads_ui.cc - Issue 288005: First fix to minimize copying of image data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/downloads_ui.cc

Issue 288005: First fix to minimize copying of image data. (Closed)

Patch Set: Modify gyp Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/dom_ui/downloads_ui.cc

diff --git a/chrome/browser/dom_ui/downloads_ui.cc b/chrome/browser/dom_ui/downloads_ui.cc

index 52a26dfebd3de1ea671f38dea926197a94712c8a..3de6f5a7fb7d15cb071244334ecfcc51ddb7dea6 100644

--- a/chrome/browser/dom_ui/downloads_ui.cc

+++ b/chrome/browser/dom_ui/downloads_ui.cc

@@ -139,7 +139,7 @@ DownloadsUI::DownloadsUI(TabContents* contents) : DOMUI(contents) {

}

// static

-bool DownloadsUI::GetFaviconResourceBytes(std::vector<unsigned char>* bytes) {

+RefCountedMemory* DownloadsUI::GetFaviconResourceBytes() {

return ResourceBundle::GetSharedInstance().

- LoadImageResourceBytes(IDR_DOWNLOADS_FAVICON, bytes);

+ LoadImageResourceBytes(IDR_DOWNLOADS_FAVICON);

}