Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4641)

Unified Diff: chrome/browser/dom_ui/dom_ui_factory.cc

Issue 288005: First fix to minimize copying of image data. (Closed)
Patch Set: Modify gyp Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/dom_ui_factory.cc
diff --git a/chrome/browser/dom_ui/dom_ui_factory.cc b/chrome/browser/dom_ui/dom_ui_factory.cc
index cdfbd7f3f65699f99f926a454a5a69e169f23ed4..ad98860275e9caa632b7401616bc005cd1668129 100644
--- a/chrome/browser/dom_ui/dom_ui_factory.cc
+++ b/chrome/browser/dom_ui/dom_ui_factory.cc
@@ -120,16 +120,16 @@ DOMUI* DOMUIFactory::CreateDOMUIForURL(TabContents* tab_contents,
}
// static
-bool DOMUIFactory::GetFaviconResourceBytes(const GURL& page_url,
- std::vector<unsigned char>* bytes) {
+RefCountedMemory* DOMUIFactory::GetFaviconResourceBytes(
+ const GURL& page_url) {
if (!HasDOMUIScheme(page_url))
- return false;
+ return NULL;
if (page_url.host() == chrome::kChromeUIHistoryHost)
- return HistoryUI::GetFaviconResourceBytes(bytes);
+ return HistoryUI::GetFaviconResourceBytes();
if (page_url.host() == chrome::kChromeUIDownloadsHost)
- return DownloadsUI::GetFaviconResourceBytes(bytes);
+ return DownloadsUI::GetFaviconResourceBytes();
- return false;
+ return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698