chrome/browser/favicon_service.h - Issue 288005: First fix to minimize copying of image data.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/favicon_service.h

Issue 288005: First fix to minimize copying of image data. (Closed)

Patch Set: Modify gyp Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/browser_theme_provider.cc ('K') | « chrome/browser/fav_icon_helper.h ('k') | chrome/browser/favicon_service.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_FAVICON_SERVICE_H__	5 #ifndef CHROME_BROWSER_FAVICON_SERVICE_H__

6 #define CHROME_BROWSER_FAVICON_SERVICE_H__	6 #define CHROME_BROWSER_FAVICON_SERVICE_H__

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/ref_counted.h"	10 #include "base/ref_counted.h"

	11 #include "base/ref_counted_memory.h"

11 #include "base/task.h"	12 #include "base/task.h"

12 #include "chrome/browser/cancelable_request.h"	13 #include "chrome/browser/cancelable_request.h"

13 #include "chrome/browser/history/history_types.h"	14 #include "chrome/browser/history/history_types.h"

14 #include "chrome/common/notification_observer.h"	15 #include "chrome/common/notification_observer.h"

15 #include "chrome/common/ref_counted_util.h"	16 #include "chrome/common/ref_counted_util.h"

16	17

17 class GURL;	18 class GURL;

18 class Profile;	19 class Profile;

19	20

20 // The favicon service provides methods to access favicons. It calls the history	21 // The favicon service provides methods to access favicons. It calls the history

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 private:	89 private:

89 Profile* profile_;	90 Profile* profile_;

90	91

91 // Helper to forward an empty result if we cannot get the history service.	92 // Helper to forward an empty result if we cannot get the history service.

92 void ForwardEmptyResultAsync(GetFaviconRequest* request);	93 void ForwardEmptyResultAsync(GetFaviconRequest* request);

93	94

94 DISALLOW_COPY_AND_ASSIGN(FaviconService);	95 DISALLOW_COPY_AND_ASSIGN(FaviconService);

95 };	96 };

96	97

97 #endif // CHROME_BROWSER_FAVICON_SERVICE_H__	98 #endif // CHROME_BROWSER_FAVICON_SERVICE_H__

OLD	NEW